Bug in Multiview Search requester

A forum for general AmigaOS 4.x support questions that are not platform-specific

Re: Bug in Multiview Search requester

Postby salass00 » Thu Nov 02, 2017 12:28 pm

As far as corrupted characters popping up in the string gadgets of the ASL requesters this is IMHO probably due to the way that asl.library interacts with the string gadgets and is IIRC not something that is easily fixed. Either any code that modifies the string contents should be made to never leave the string in a state without proper nul-termination (might involve using Forbid()) or there needs to be some way to read the contents of the string gadget with proper locking (STRINGA_TextVal is AFAICT not really safe to read and use while the string is might be being edited).

Fortunately for the MultiView search requester these problems should not apply there because it only needs to read the string value after the window has been closed.
User avatar
salass00
AmigaOS Core Developer
AmigaOS Core Developer
 
Posts: 498
Joined: Sat Jun 18, 2011 4:12 pm
Location: Finland

Re: Bug in Multiview Search requester

Postby xenic » Thu Nov 02, 2017 4:52 pm

Raziel wrote: I can't even find such an option to patch requesters, so i believe i'm not using it.

You would know it if your ASL is patched; the patched ASL requester is obviously an MUI window. It's not an MUI preferences item. If you install MUI with the installer in the MUI directory (MUI/Install-MUI) there is an option to add the patch to your user-startup. It looks like this:

;BEGIN MUI ASL
if exists "SYS:MUI"
run <>nil: MUI:PatchASL
endif
;END MUI ASL

It runs the PatchASL utility in the MUI directory. If you install MUI with AutoInstall, I don't think you get the patch option for some reason.

EDIT: Now that I think of it, you might want to try the MUI ASL patch to see if your problem occurs with the MUI ASL requester too. Just enter "MUI:PatchASL" in a shell before conducting your test. Of course you'll need to reboot to get rid of the patch after testing.
AmigaOne X1000 with 2GB memory - OS4.1 FE
xenic
 
Posts: 1066
Joined: Sun Jun 19, 2011 1:06 am

Re: Bug in Multiview Search requester

Postby Raziel » Thu Nov 02, 2017 10:39 pm

xenic wrote:
Raziel wrote: I can't even find such an option to patch requesters, so i believe i'm not using it.

You would know it if your ASL is patched; the patched ASL requester is obviously an MUI window. It's not an MUI preferences item. If you install MUI with the installer in the MUI directory (MUI/Install-MUI) there is an option to add the patch to your user-startup. It looks like this:

;BEGIN MUI ASL
if exists "SYS:MUI"
run <>nil: MUI:PatchASL
endif
;END MUI ASL

It runs the PatchASL utility in the MUI directory. If you install MUI with AutoInstall, I don't think you get the patch option for some reason.

EDIT: Now that I think of it, you might want to try the MUI ASL patch to see if your problem occurs with the MUI ASL requester too. Just enter "MUI:PatchASL" in a shell before conducting your test. Of course you'll need to reboot to get rid of the patch after testing.

Nope, no patch installed here.

And i think i skip the testing of third party patches for now, until there's a solution for this bug.

But thank you for the hints
If slaughterhouses had glass walls, everyone would be a vegetarian. ~ Sir Paul McCartney
-
Did everything just taste purple for a second? ~ Philip J. Fry
-
Ain't got no cash, ain't got no style, ladies vomit when I smile. ~ Dr. John Zoidberg
User avatar
Raziel
 
Posts: 774
Joined: Sat Jun 18, 2011 5:00 pm
Location: A haunted Castle somewhere in the Bavarian Mountains

Previous

Return to General AmigaOS

Who is online

Users browsing this forum: No registered users and 4 guests