Bug in Multiview Search requester

A forum for general AmigaOS 4.x support questions that are not platform-specific

Re: Bug in Multiview Search requester

Postby Raziel » Wed Nov 01, 2017 12:43 am

xenic wrote:
Raziel wrote:Because i lately get more and more instances of file names (e.g. pictures i save to or rename, pictures i convert to other formats and save and such) getting a trailing letter "n" added to my file name (just like it was with the seach field).


I previously tried to reproduce the search bug with my X1000 but I tried again with your example file on my X5000 and could not reproduce it. With regard to your letter "n" problem; my AmigaONE keyboard that I got with my X1000 is now producing double "t" letters instead of a single "t" (i.e. tt instead of t). In light of that problem, I would suggest you try a different keyboard.

It's not the keyboard as the letter "n" is printed AFTER the file name.
If slaughterhouses had glass walls, everyone would be a vegetarian. ~ Sir Paul McCartney
-
Did everything just taste purple for a second? ~ Philip J. Fry
-
Ain't got no cash, ain't got no style, ladies vomit when I smile. ~ Dr. John Zoidberg
User avatar
Raziel
 
Posts: 781
Joined: Sat Jun 18, 2011 5:00 pm
Location: A haunted Castle somewhere in the Bavarian Mountains

Re: Bug in Multiview Search requester

Postby Raziel » Wed Nov 01, 2017 4:20 pm

I just tried again:

These are the steps to bring it up:
Have some pictutres ready

1) Load a picture in Multiviewer
2) Mark part of the picture
3 Copy the marked area
4) Paste the amrked area (new project opens in Multiviewer)
5) Save as ... PNG

First time nothing happens, all is normal, name for the saved file is "01.png"
The next picture though (following the steps above, it starts adding those characters again)
"01.pngnþ" is what Multiviewer is giving as name suggestion for the second file (where do those characters come from?)
If slaughterhouses had glass walls, everyone would be a vegetarian. ~ Sir Paul McCartney
-
Did everything just taste purple for a second? ~ Philip J. Fry
-
Ain't got no cash, ain't got no style, ladies vomit when I smile. ~ Dr. John Zoidberg
User avatar
Raziel
 
Posts: 781
Joined: Sat Jun 18, 2011 5:00 pm
Location: A haunted Castle somewhere in the Bavarian Mountains

Re: Bug in Multiview Search requester

Postby ZeroG » Wed Nov 01, 2017 4:38 pm

@Raziel
Multiviewer is not part of the OS, or did you mean Multiview?
User avatar
ZeroG
 
Posts: 117
Joined: Sat Jun 18, 2011 12:31 pm
Location: Germany

Re: Bug in Multiview Search requester

Postby broadblues » Wed Nov 01, 2017 4:49 pm

"01.pngnþ" is what Multiviewer is giving as name suggestion for the second file (where do those characters come from?)


The characters come from a missing nulll terminator somewhere in the process, the sequance you should above matches "ABADCAFE" if I'm not mistaken, meaning the string has overrun into non initailsed memeory somewhere.

THis type of bug related to the string gadget has popped up a few times IIRC I wonder if there is sn incorrect buffer size somewhere, off by 1 perhaps.
User avatar
broadblues
AmigaOS Core Developer
AmigaOS Core Developer
 
Posts: 521
Joined: Sat Jun 18, 2011 3:40 am
Location: Portsmouth, UK

Re: Bug in Multiview Search requester

Postby broadblues » Wed Nov 01, 2017 4:52 pm

ZeroG wrote:@Raziel
Multiviewer is not part of the OS, or did you mean Multiview?


He probably means MultiViewer, but don't dismiss it out of hand because MVer is third party, it's built from system components after all.

In this case the filerequester uses a persistant ASL Object, perhaps there is an issue in asl. I've not seen the problem though.
User avatar
broadblues
AmigaOS Core Developer
AmigaOS Core Developer
 
Posts: 521
Joined: Sat Jun 18, 2011 3:40 am
Location: Portsmouth, UK

Re: Bug in Multiview Search requester

Postby xenic » Wed Nov 01, 2017 5:38 pm

Raziel wrote:First time nothing happens, all is normal, name for the saved file is "01.png"
The next picture though (following the steps above, it starts adding those characters again)
"01.pngnþ" is what Multiviewer is giving as name suggestion for the second file (where do those characters come from?)


I tried the above procedure with both Multiview and Multiviewer. I was unable to reproduce the problem on my X5000. As Broadblues implied, this seems like a string gadget issue. However, when I installed the latest MUI I noticed that it can patch the ASL requester. Are you using the MUI patched ASL requester? Dopus5 patches a number of system libraries. Are you using Dopus5 or any other application that patches system libraries or gadgets?

There must be something different about your system if you can easily reproduce the problem but others can't.
AmigaOne X1000 with 2GB memory - OS4.1 FE
xenic
 
Posts: 1094
Joined: Sun Jun 19, 2011 1:06 am

Re: Bug in Multiview Search requester

Postby xenic » Wed Nov 01, 2017 5:51 pm

broadblues wrote:In this case the filerequester uses a persistant ASL Object, perhaps there is an issue in asl. I've not seen the problem though.


As I mentioned to Raziel the latest MUI can patch the ASL requester which could further complicate diagnosing the problem.
AmigaOne X1000 with 2GB memory - OS4.1 FE
xenic
 
Posts: 1094
Joined: Sun Jun 19, 2011 1:06 am

Re: Bug in Multiview Search requester

Postby Raziel » Thu Nov 02, 2017 11:34 am

broadblues wrote:
"01.pngnþ" is what Multiviewer is giving as name suggestion for the second file (where do those characters come from?)


The characters come from a missing nulll terminator somewhere in the process, the sequance you should above matches "ABADCAFE" if I'm not mistaken, meaning the string has overrun into non initailsed memeory somewhere.

THis type of bug related to the string gadget has popped up a few times IIRC I wonder if there is sn incorrect buffer size somewhere, off by 1 perhaps.

See?
That is the kind of answer i was expecting :-)

Thanks a lot for this and thank you also for more info so i can take a deeper look what may be going on.

It really does sound like it's a problem in a system component as it sometimes pops up in other programs as well, but not that often, of course, have seen it only once in another text input field from another program, can't remember which one.
If slaughterhouses had glass walls, everyone would be a vegetarian. ~ Sir Paul McCartney
-
Did everything just taste purple for a second? ~ Philip J. Fry
-
Ain't got no cash, ain't got no style, ladies vomit when I smile. ~ Dr. John Zoidberg
User avatar
Raziel
 
Posts: 781
Joined: Sat Jun 18, 2011 5:00 pm
Location: A haunted Castle somewhere in the Bavarian Mountains

Re: Bug in Multiview Search requester

Postby Raziel » Thu Nov 02, 2017 11:35 am

xenic wrote:
Raziel wrote:First time nothing happens, all is normal, name for the saved file is "01.png"
The next picture though (following the steps above, it starts adding those characters again)
"01.pngnþ" is what Multiviewer is giving as name suggestion for the second file (where do those characters come from?)


I tried the above procedure with both Multiview and Multiviewer. I was unable to reproduce the problem on my X5000. As Broadblues implied, this seems like a string gadget issue. However, when I installed the latest MUI I noticed that it can patch the ASL requester. Are you using the MUI patched ASL requester? Dopus5 patches a number of system libraries. Are you using Dopus5 or any other application that patches system libraries or gadgets?

There must be something different about your system if you can easily reproduce the problem but others can't.

I'm not using DOpus et al, never did.

MUI i have, installed is the latest version 21.83 (svn6041)
I don't think i have changed MUI to patch the ASSL requester, but i'm sure to check all my MUI settings right now.

EDIT:
I can't even find such an option to patch requesters, so i believe i'm not using it.
If slaughterhouses had glass walls, everyone would be a vegetarian. ~ Sir Paul McCartney
-
Did everything just taste purple for a second? ~ Philip J. Fry
-
Ain't got no cash, ain't got no style, ladies vomit when I smile. ~ Dr. John Zoidberg
User avatar
Raziel
 
Posts: 781
Joined: Sat Jun 18, 2011 5:00 pm
Location: A haunted Castle somewhere in the Bavarian Mountains

Re: Bug in Multiview Search requester

Postby Raziel » Thu Nov 02, 2017 11:44 am

ZeroG wrote:@Raziel
Multiviewer is not part of the OS, or did you mean Multiview?

MultiViewer was just an example and the easiest way to reproduce the problem.
Multiview and Notepad do show the same bug, but not as often as MultiViewer.
If slaughterhouses had glass walls, everyone would be a vegetarian. ~ Sir Paul McCartney
-
Did everything just taste purple for a second? ~ Philip J. Fry
-
Ain't got no cash, ain't got no style, ladies vomit when I smile. ~ Dr. John Zoidberg
User avatar
Raziel
 
Posts: 781
Joined: Sat Jun 18, 2011 5:00 pm
Location: A haunted Castle somewhere in the Bavarian Mountains

PreviousNext

Return to General AmigaOS

Who is online

Users browsing this forum: No registered users and 4 guests