Something odd in requester.h

Have a question about our Software Developer Kit? Ask them here.
Post Reply
User avatar
tbreeden
Posts: 160
Joined: Sat Jun 18, 2011 12:57 am
Location: Charlottesville, VA, USA
Contact:

Something odd in requester.h

Post by tbreeden »

The latest public release of the SDK has a set of defines like this:

requester.h 53.22 (31.1.2010)

Code: Select all

#define REQI_Minimum    (REQI_Dummy+1)
#define REQI_Maximum    (REQI_Dummy+2)
#define REQI_Invisible  (REQI_Dummy+3) /* NOT IMPLEMENTED YET */
#define REQI_Number     (REQI_Dummy+4)
#define REQI_Arrows     (REQI_Dummy+5)
#define REQI_MaxChars   (REQI_Dummy+6)
#define REQI_MinText    (REQI_Dummy+7)
#define REQI_MaxText    (REQI_Dummy+8)
#define REQI_Mark       (REQS_Dummy+9)
Is the define for REQI_Mark a typo?
It just seemed weird to me that it switches to REQS_Dummy in that line.

Tom
User avatar
salass00
AmigaOS Core Developer
AmigaOS Core Developer
Posts: 530
Joined: Sat Jun 18, 2011 3:12 pm
Location: Finland
Contact:

Re: Something odd in requester.h

Post by salass00 »

tbreeden wrote:Is the define for REQI_Mark a typo?
It just seemed weird to me that it switches to REQS_Dummy in that line.

Tom
I was going to suggest that REQI_Mark likely an alias for REQS_Mark, but it turns out it has a different value so it's probably a copy paste error (programmer changed the '+7' to '+9' but forgot to change 'REQS_Dummy' to 'REQI_Dummy'):

Code: Select all

#define REQS_Mark (REQS_Dummy+7)
User avatar
rwo
Posts: 15
Joined: Thu Mar 10, 2011 11:03 am
Location: Denmark

Re: Something odd in requester.h

Post by rwo »

I agree that it looks like a typo, so I changed it and updated the svn.

Thanks for the hint.

René
Post Reply