Page 1 of 1

Darren's new Nemo patches for the official Linux kernel

PostPosted: Thu May 03, 2018 3:58 pm
by xeno74

Re: Darren's new Nemo patches for the official Linux kernel

PostPosted: Fri Jun 29, 2018 9:20 am
by xeno74

Re: Darren's new Nemo patches for the official Linux kernel

PostPosted: Tue Jul 10, 2018 7:49 am
by xeno74
FYI:

Hi Michael,
Hi All,

kbuild test robot Wed, 03 Jan 2018 04:17:20 -0800 wrote:

Hi Darren,

Thank you for the patch! Perhaps something to improve:

arch/powerpc/platforms/pasemi/pci.c: In function 'sb600_set_flag': >> include/linux/kern_levels.h:5:18: warning: format '%lx' expects argument of >> type 'long unsigned int', but argument 2 has type 'resource_size_t {aka long >> long unsigned int}' [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */

—-

I was able to fix this small format issue. I replaced the format '%08lx' with '%08llx'.

+ printk(KERN_CRIT "NEMO SB600 IOB base %08llx\n",res.start);

Is this fix OK or is there a better solution?

On 3. May 2018, at 15:06, Michael Ellerman <mpe@ellerman.id.au> wrote:

+
+ printk(KERN_CRIT "NEMO SB600 IOB base %08lx\n",res.start);

That's INFO or even DEBUG.


Michael,

What do you think about this fix?

+ printk(KERN_INFO "NEMO SB600 IOB base %08llx\n",res.start);

Thanks,
Christian

Re: Darren's new Nemo patches for the official Linux kernel

PostPosted: Tue Jul 10, 2018 6:55 pm
by xeno74
FYI

Michael wrote:pr_info() would be nice.

But I replied with lots of other comments previously.

None of them were super critical, but it would be nice to get them fixed
before merging if possible.

cheers

Re: Darren's new Nemo patches for the official Linux kernel

PostPosted: Tue Jul 10, 2018 7:23 pm
by xeno74
FYI

Hello Michael,

Thanks a lot for your reply. OK, first I would like to add

pr_info("NEMO SB600 IOB base %08llx\n",res.start)

to the Nemo patch. Is this line correct now?

After that I will try to contact Darren because of your other comments.

If I don’t reach Darren then I will try to fix the issues but I think I need your help for fixing them.

Thanks,
Christian

Re: Darren's new Nemo patches for the official Linux kernel

PostPosted: Wed Jul 11, 2018 10:41 pm
by xeno74
FYI

Christian Zigotzky <chzigotzky@xenosoft.de> writes:

> Hello Michael,
>
> Thanks a lot for your reply. OK, first I would like to add
>
> pr_info("NEMO SB600 IOB base %08llx\n",res.start)
>
> to the Nemo patch. Is this line correct now?

Yes I think so.

The type of start is resource_size_t, which can be 32 or 64-bits. But in
this code it should always be 64-bit.

> After that I will try to contact Darren because of your other comments.
>
> If I don’t reach Darren then I will try to fix the issues but I think
> I need your help for fixing them.

Sure.

cheers