Commodities CX_POPKEY bug
Commodities CX_POPKEY bug
The ContextMenus commodity and the CrossDOS commodity both have the same default CX_POPKEY (ctrl alt c). Only the last one started will respond to the popkey. Could someone confirm and add it to the bugzilla?
AmigaOne X1000 with 2GB memory - OS4.1 FE
- tonyw
- AmigaOS Core Developer
- Posts: 1479
- Joined: Wed Mar 09, 2011 1:36 pm
- Location: Sydney, Australia
Re: Commodities CX_POPKEY bug
I see that in both commodities, the active key can be changed via tooltypes, so it's not a disaster.
However, I'll raise a BZ on both components - let the maintainers sort out the differences.
[edit]
Bugs #9338 and 9339 raised.
[/edit]
However, I'll raise a BZ on both components - let the maintainers sort out the differences.
[edit]
Bugs #9338 and 9339 raised.
[/edit]
cheers
tony
tony
Re: Commodities CX_POPKEY bug
Thanks. It's a minor issue but some of us just add commodities to WBStartup without changing the tooltypes. It'll be better if they work with the default settings.tonyw wrote:I see that in both commodities, the active key can be changed via tooltypes, so it's not a disaster.
However, I'll raise a BZ on both components - let the maintainers sort out the differences.
[edit]
Bugs #9338 and 9339 raised.
[/edit]
AmigaOne X1000 with 2GB memory - OS4.1 FE
- Daedalus
- Posts: 42
- Joined: Sat Jun 18, 2011 12:30 am
- Location: From Ireland, living in Glasgow
- Contact:
Re: Commodities CX_POPKEY bug
Is it not the case that the Commodities system should pass through these key combinations for use by other applications? Or is that down to individual developers' preferences? I know that the default shortcut for SGrab and SMBMounter are both the same (ctrl-alt-S), and pressing it when both are running causes both to pop up, regardless of start order.xenic wrote:Only the last one started will respond to the popkey. Could someone confirm and add it to the bugzilla?
- thomasrapp
- Posts: 310
- Joined: Sat Jun 18, 2011 11:22 pm
Re: Commodities CX_POPKEY bug
Normally a commodity should "eat" its hotkey. It is bad coding style to let it pass. If you let it pass, it does not only arrive at other commodities, but also at the application which is currently active. This might lead to confusion at best and to unwanted action in the worst case.
Re: Commodities CX_POPKEY bug
I tested with several commodities and only the first one launched pops up when they have the same shortcut. Maybe SMBMounter is accessing the Input device directly or some other method. I'm not sure if having multiple windows open for the same shortcut is a good idea. It would be nice if Exchange would display the shortcut (hotkey) for a commodity when you click on it in the Exchange lister. There's room at the bottom of the Exchange window for at least one more line of text. I'm working on my own commodity and it would be helpful if there was a way to tell what shortcuts are already used other than opening information on each commodity icon.Daedalus wrote:Is it not the case that the Commodities system should pass through these key combinations for use by other applications? Or is that down to individual developers' preferences? I know that the default shortcut for SGrab and SMBMounter are both the same (ctrl-alt-S), and pressing it when both are running causes both to pop up, regardless of start order.xenic wrote:Only the last one started will respond to the popkey. Could someone confirm and add it to the bugzilla?
AmigaOne X1000 with 2GB memory - OS4.1 FE
- Daedalus
- Posts: 42
- Joined: Sat Jun 18, 2011 12:30 am
- Location: From Ireland, living in Glasgow
- Contact:
Re: Commodities CX_POPKEY bug
Good to know... I always thought commodities passed everything through as they sit in the input stream, in case the key was also used for something else, but it does make sense to swallow the hotkey. I'll have a look at changing that for the next SMBMounter update.thomasrapp wrote:Normally a commodity should "eat" its hotkey. It is bad coding style to let it pass. If you let it pass, it does not only arrive at other commodities, but also at the application which is currently active. This might lead to confusion at best and to unwanted action in the worst case.